Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first

From: Chao Yu
Date: Tue May 11 2021 - 23:11:10 EST


On 2021/5/12 9:28, Chao Yu wrote:
On 2021/5/12 5:43, Jaegeuk Kim wrote:
The final solution can be migrating blocks to form a section-aligned file
internally. Meanwhile, let's ask users to do that when preparing the swap
file initially like:
1) create()
2) ioctl(F2FS_IOC_SET_PIN_FILE)
3) fallocate()

Let me take a look how to migrate unaligned swapfile during swapon(). :)


Reported-by: kernel test robot <oliver.sang@xxxxxxxxx>
Fixes: 36e4d95891ed ("f2fs: check if swapfile is section-alligned")
Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Wait, shouldn't this cover check_swap_activate_fast() as well?

Thanks,


Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
.