Re: [PATCH] virtiofs: Enable multiple request queues

From: Connor Kuehl
Date: Tue May 11 2021 - 10:42:07 EST


On 5/11/21 5:23 AM, Stefan Hajnoczi wrote:
> On Fri, May 07, 2021 at 05:15:27PM -0500, Connor Kuehl wrote:
>> @@ -1245,7 +1262,8 @@ __releases(fiq->lock)
>> req->in.h.nodeid, req->in.h.len,
>> fuse_len_args(req->args->out_numargs, req->args->out_args));
>>
>> - fsvq = &fs->vqs[queue_id];
>> + fsvq = this_cpu_read(this_cpu_fsvq);
>
> Please check how CPU hotplug affects this patch. If the current CPU
> doesn't have a vq because it was hotplugged, then it may be necessary to
> pick another vq.

I'll fix this in the next revision.

Thanks,

Connor