RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support

[Nava kishore Manne]

Hi Moritz,

Please find my response inline.

> -----Original Message-----
> From: Moritz Fischer <mdf@xxxxxxxxxx>
> Sent: Monday, May 10, 2021 11:14 PM
> To: Nava kishore Manne <navam@xxxxxxxxxx>
> Cc: Moritz Fischer <mdf@xxxxxxxxxx>; trix@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>; linux-
> fpga@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; git
> <git@xxxxxxxxxx>; chinnikishore369@xxxxxxxxx
> Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading support
> 
> On Wed, Mar 03, 2021 at 10:11:51AM +0000, Nava kishore Manne wrote:
> > Ping!
> >
> > > -----Original Message-----
> > > From: Nava kishore Manne
> > > Sent: Wednesday, January 27, 2021 2:43 PM
> > > To: Moritz Fischer <mdf@xxxxxxxxxx>
> > > Cc: trix@xxxxxxxxxx; robh+dt@xxxxxxxxxx; Michal Simek
> > > <michals@xxxxxxxxxx>; linux-fpga@xxxxxxxxxxxxxxx;
> > > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > > linux- kernel@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>;
> > > chinnikishore369@xxxxxxxxx
> > > Subject: RE: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading
> > > support
> > >
> > > Hi Moritz,
> > >
> > > 	Thanks for the review.
> > > Please find my response inline.
> > >
> > > > -----Original Message-----
> > > > From: Moritz Fischer <mdf@xxxxxxxxxx>
> > > > Sent: Friday, January 22, 2021 10:47 AM
> > > > To: Nava kishore Manne <navam@xxxxxxxxxx>
> > > > Cc: mdf@xxxxxxxxxx; trix@xxxxxxxxxx; robh+dt@xxxxxxxxxx; Michal
> > > > Simek <michals@xxxxxxxxxx>; linux-fpga@xxxxxxxxxxxxxxx;
> > > > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> > > > linux- kernel@xxxxxxxxxxxxxxx; git <git@xxxxxxxxxx>;
> > > > chinnikishore369@xxxxxxxxx
> > > > Subject: Re: [PATCH 1/2] fpga: mgr: Adds secure BitStream loading
> > > > support
> > > >
> > > > On Mon, Jan 18, 2021 at 08:20:57AM +0530, Nava kishore Manne
> wrote:
> > > > > This commit adds secure flags to the framework to support secure
> > > > > BitStream Loading.
> > > > >
> > > > > Signed-off-by: Nava kishore Manne <nava.manne@xxxxxxxxxx>
> > > > > ---
> > > > >  drivers/fpga/of-fpga-region.c | 10 ++++++++++
> > > > > include/linux/fpga/fpga-mgr.h | 12 ++++++++++++
> > > > >  2 files changed, 22 insertions(+)
> > > > >
> > > > > diff --git a/drivers/fpga/of-fpga-region.c
> > > > > b/drivers/fpga/of-fpga-region.c index e405309baadc..3a5eb4808888
> > > > > 100644
> > > > > --- a/drivers/fpga/of-fpga-region.c
> > > > > +++ b/drivers/fpga/of-fpga-region.c
> > > > > @@ -228,6 +228,16 @@ static struct fpga_image_info
> > > > *of_fpga_region_parse_ov(
> > > > >  	if (of_property_read_bool(overlay, "encrypted-fpga-config"))
> > > > >  		info->flags |= FPGA_MGR_ENCRYPTED_BITSTREAM;
> > > > >
> > > > > +	if (of_property_read_bool(overlay, "userkey-encrypted-fpga-
> > > > config"))
> > > > > +		info->flags |=
> > > > FPGA_MGR_USERKEY_ENCRYPTED_BITSTREAM;
> > > >
> > > > Can this just be encrypted-fpga-config/FPGA_MGR_ENCRYPTED?
> > >
> > > In Encryption we have two kinds of use case one is Encrypted
> > > Bitstream loading with Device-key and Other one is Encrypted
> > > Bitstream loading with User-key. To differentiate both the use cases this
> Changes are needed.
> > >
> > > Regards,
> > > Navakishore.
> 
> Is this region specific, or could this be a sysfs attribute?
> 

These changes are region specific.

Regards,
Navakishore.