Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported

From: Vlastimil Babka
Date: Tue May 11 2021 - 04:36:05 EST


On 5/10/21 5:38 PM, Hyeonggon Yoo wrote:
> On Mon, May 10, 2021 at 05:19:58PM +0200, Vlastimil Babka wrote:
>
>> I'd rephrase the subject:
>> mm, slub: change run-time assertion in kmalloc_index() to compile-time
>>
>
>> "... compiler will generate a run-time BUG() while a compile-time error is also
>> possible, and better"
>
>> "there's no need to..."
>> kmalloc-32M
>
>
> Vlastimil Babka and Christoph Lameter, thank you for reviewing the patch.
>
> I'm not familiar with kernel community yet. should I send patch v3 again,
> or can you update it directly?

I think it would be best if you sent v3, the way you did with v1 - inline. With
v2 it looked like a mail body with you message and patch as attachment. We want
the testing bots to pick it up and they might work only with inline patch. Thanks.