Re: [PATCH v3 3/5] Bluetooth: btqca: Moved extracting rom version info to common place

[gubbaven]

Hi Marcel,
On 2021-05-07 13:23, Marcel Holtmann wrote:
> Hi Venkata,
>
> > Moved extracting rom version info to common place as this code is
> > common in all if else ladder in qca_uart_setup.
> >
> > Signed-off-by: Venkata Lakshmi Narayana Gubba 
> > <gubbaven@xxxxxxxxxxxxxx>
> > ---
> > drivers/bluetooth/btqca.c | 15 ++++++---------
> > 1 file changed, 6 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> > index 320c555..658fd8e4 100644
> > --- a/drivers/bluetooth/btqca.c
> > +++ b/drivers/bluetooth/btqca.c
> > @@ -533,24 +533,21 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t 
> > baudrate,
> >
> > 	config.user_baud_rate = baudrate;
> >
> > +	/* Firmware files to download are based on ROM version.
> > +	 * ROM version is derived from last two bytes of soc_ver.
> > +	 */
> > +	rom_ver = ((soc_ver & 0x00000f00) >> 0x04) |
> > +		    (soc_ver & 0x0000000f);
> > +
>
> please try to align this properly.
[Venkata]:
Sure, I will update in next patchset.
> Regards
>
> Marcel

Regards,
Lakshmi Narayana.