Re: [PATCH v1 1/1] hwmon: (lm70) Use SPI_MODE_X_MASK

From: Guenter Roeck
Date: Mon May 10 2021 - 11:24:23 EST


On Mon, May 10, 2021 at 05:13:31PM +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/lm70.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
> index 40eab3349904..cdf23a59a203 100644
> --- a/drivers/hwmon/lm70.c
> +++ b/drivers/hwmon/lm70.c
> @@ -184,7 +184,7 @@ static int lm70_probe(struct spi_device *spi)
>
>
> /* signaling is SPI_MODE_0 */
> - if (spi->mode & (SPI_CPOL | SPI_CPHA))
> + if ((spi->mode & SPI_MODE_X_MASK) != SPI_MODE_0)
> return -EINVAL;
>
> /* NOTE: we assume 8-bit words, and convert to 16 bits manually */