Re: [PATCH 5.10 108/299] platform/x86: intel_pmc_core: Dont use global pmcdev in quirks

From: Pavel Machek
Date: Mon May 10 2021 - 08:51:57 EST


Hi!

> From: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
>
> [ Upstream commit c9f86d6ca6b5e23d30d16ade4b9fff5b922a610a ]
>
> The DMI callbacks, used for quirks, currently access the PMC by getting
> the address a global pmc_dev struct. Instead, have the callbacks set a
> global quirk specific variable. In probe, after calling dmi_check_system(),
> pass pmc_dev to a function that will handle each quirk if its variable
> condition is met. This allows removing the global pmc_dev later.

This does not fix a bug.. it is preparation for further cleanups that
are not queued to 5.10 stable. So this should not be in 5.10 either.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature