Re: [PATCH v23 8/9] mm: memory_hotplug: disable memmap_on_memory when hugetlb_free_vmemmap enabled

From: Oscar Salvador
Date: Mon May 10 2021 - 06:08:24 EST


On Mon, May 10, 2021 at 11:00:26AM +0800, Muchun Song wrote:
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index 8cc195c4c861..0d7f595ee441 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -15,6 +15,7 @@
> #include <linux/acpi.h>
> #include <linux/memory.h>
> #include <linux/memory_hotplug.h>
> +#include <linux/hugetlb.h>
>
> #include "internal.h"

Uhm, I am confused.
Why do we need this here? AFAICS, we do not.

The function is in memory_hotplug.c, and that alrady has that include.
What am I missing?


--
Oscar Salvador
SUSE L3