Re: [PATCH] RDMA/mlx4: Remove unnessesary check in mlx4_ib_modify_wq()

From: Leon Romanovsky
Date: Sun May 09 2021 - 05:00:44 EST


On Fri, May 07, 2021 at 06:22:41PM +0800, Jiapeng Chong wrote:
> cur_state and new_state are enums and when GCC considers
> them as unsigned, the conditions are never met.
>
> Clean up the following smatch warning:
>
> drivers/infiniband/hw/mlx4/qp.c:4258 mlx4_ib_modify_wq() warn: unsigned
> 'cur_state' is never less than zero.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/mlx4/qp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>