Re: [RFC PATCH net-next v4 01/28] net: mdio: ipq8064: clean whitespaces in define

From: Joe Perches
Date: Sat May 08 2021 - 11:57:54 EST


On Sat, 2021-05-08 at 02:28 +0200, Ansuel Smith wrote:
> Fix mixed whitespace and tab for define spacing.

Incomplete commit message here.

> diff --git a/drivers/net/mdio/mdio-ipq8064.c b/drivers/net/mdio/mdio-ipq8064.c
[]
> -#define MII_CLKRANGE_60_100M (0 << 2)
> -#define MII_CLKRANGE_100_150M (1 << 2)
> -#define MII_CLKRANGE_20_35M (2 << 2)
> -#define MII_CLKRANGE_35_60M (3 << 2)
> -#define MII_CLKRANGE_150_250M (4 << 2)
> -#define MII_CLKRANGE_250_300M (5 << 2)
[]
> +#define MII_CLKRANGE(x) ((x) << 2)
> +#define MII_CLKRANGE_60_100M MII_CLKRANGE(0)
> +#define MII_CLKRANGE_100_150M MII_CLKRANGE(1)
> +#define MII_CLKRANGE_20_35M MII_CLKRANGE(2)
> +#define MII_CLKRANGE_35_60M MII_CLKRANGE(3)
> +#define MII_CLKRANGE_150_250M MII_CLKRANGE(4)
> +#define MII_CLKRANGE_250_300M MII_CLKRANGE(5)

Adding a define and using it isn't just whitespace.