Re: [PATCH v4 6/6] bus: mhi: core: Add range checks for BHI and BHIe

From: Hemant Kumar
Date: Thu May 06 2021 - 22:33:25 EST




On 5/6/21 12:51 PM, Bhaumik Bhatt wrote:
When obtaining the BHI or BHIe offsets during the power up
preparation phase, range checks are missing. These can help
controller drivers avoid accessing any address outside of the
MMIO region. Ensure that mhi_cntrl->reg_len is set before MHI
registration as it is a required field and range checks will
fail without it.

Signed-off-by: Bhaumik Bhatt <bbhatt@xxxxxxxxxxxxxx>
Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>

Reviewed-by: Hemant Kumar <hemantk@xxxxxxxxxxxxxx>

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project