Re: [PATCH] HID: ft260: check data size in ft260_smbus_write()

From: Jiri Kosina
Date: Wed May 05 2021 - 08:33:19 EST


On Tue, 13 Apr 2021, Michael Zaidman wrote:

> Fixes: 98189a0adfa0 ("HID: ft260: add usb hid to i2c host bridge driver")
>
> The SMbus block transaction limits the number of bytes transferred to 32,
> but nothing prevents a user from specifying via ioctl a larger data size
> than the ft260 can handle in a single transfer.
>
> i2cdev_ioctl_smbus()
> --> i2c_smbus_xfer
> --> __i2c_smbus_xfer
> --> ft260_smbus_xfer
> --> ft260_smbus_write
>
> This patch adds data size checking in the ft260_smbus_write().
>
> Signed-off-by: Michael Zaidman <michael.zaidman@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

I have moved the 'Fixes:' tag to place where it belongs, and applied.
Thanks,

--
Jiri Kosina
SUSE Labs