Re: [RFC PATCH net-next v3 20/20] net: phy: add qca8k driver for qca8k switch internal PHY

From: Andrew Lunn
Date: Tue May 04 2021 - 21:11:43 EST


> +/* QCA specific MII registers access function */
> +static void qca8k_phy_dbg_write(struct mii_bus *bus, int phy_addr, u16 dbg_addr, u16 dbg_data)
> +{
> + mutex_lock_nested(&bus->mdio_lock, MDIO_MUTEX_NESTED);
> + bus->write(bus, phy_addr, MII_ATH_DBG_ADDR, dbg_addr);
> + bus->write(bus, phy_addr, MII_ATH_DBG_DATA, dbg_data);
> + mutex_unlock(&bus->mdio_lock);
> +}

What are you locking against here?

Andrew