Re: [Outreachy kernel] Re: [PATCH v7] staging: unisys: visorhba: Convert module from IDR to XArray

From: Matthew Wilcox
Date: Tue May 04 2021 - 10:01:47 EST


On Tue, May 04, 2021 at 03:58:02PM +0200, Fabio M. De Francesco wrote:
> On Tuesday, May 4, 2021 3:42:16 PM CEST Matthew Wilcox wrote:
> > On Tue, May 04, 2021 at 03:32:53PM +0200, Fabio M. De Francesco wrote:
> > > Changes from v6; Added a call to xa_destroy() that I had forgotten.
> >
> > What? No! Go back and re-read what I wrote about this previously.
> >
> I remember that explanation you gave me some days ago for not using it. But I
> was mislead by a comment ("Do we not have to call xa_destroy()?") by Dan and
> your "Correct" soon after the above comment. So I thought that I had
> misunderstand and the put back that call to xa_destroy(). I lost something in
> following the flow of the reviews, I suppose.

English doesn't have the equivalent of the French 'si' or German 'doch',
unfortunately. I imagine Italian does.