Re: [PATCH 114/190] Revert "staging: rtl8188eu: Fix potential NULL pointer dereference of kcalloc"

From: Greg Kroah-Hartman
Date: Tue Apr 27 2021 - 07:53:52 EST


On Wed, Apr 21, 2021 at 06:55:59PM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/21/21 2:59 PM, Greg Kroah-Hartman wrote:
> > This reverts commit 7671ce0d92933762f469266daf43bd34d422d58c.
> >
> > Commits from @umn.edu addresses have been found to be submitted in "bad
> > faith" to try to test the kernel community's ability to review "known
> > malicious" changes. The result of these submissions can be found in a
> > paper published at the 42nd IEEE Symposium on Security and Privacy
> > entitled, "Open Source Insecurity: Stealthily Introducing
> > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
> > of Minnesota) and Kangjie Lu (University of Minnesota).
> >
> > Because of this, all submissions from this group must be reverted from
> > the kernel tree and will need to be re-reviewed again to determine if
> > they actually are a valid fix. Until that work is complete, remove this
> > change to ensure that no problems are being introduced into the
> > codebase.
> >
> > Cc: Aditya Pakki <pakki001@xxxxxxx>
> > Cc: Mukesh Ojha <mojha@xxxxxxxxxxxxxx>
> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> FWIW the original commit seems fine here. So if that is an option please
> drop this revert from the set.

Revert is now dropped, thanks for looking at it.

greg k-h