RE: [Patch v2 2/2] PCI: hv: Remove unused refcount and supporting functions for handling bus device removal

From: Long Li
Date: Fri Apr 23 2021 - 14:40:19 EST


> Subject: RE: [Patch v2 2/2] PCI: hv: Remove unused refcount and supporting
> functions for handling bus device removal
>
> > From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx>
> > Sent: Wednesday, April 21, 2021 10:46 PM
> >
> > With the new method of flushing/stopping the workqueue before doing
> > bus removal, the old mechanisum of using refcount and wait for
> > completion
>
> mechanisum -> mechanism
>
> > is no longer needed. Remove those dead code.
> >
> > Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
> > ---
>
> The patch looks good to me. BTW, can we also remove get_pcichild() and
> put_pcichild() in an extra patch? I suspect we don't really need those either.

Those two functions are for protecting accessing to the devices on the hbus. There are interactions from PCI layer that need guarantee from hbus that the device is present at the time of access.

Why do you think we don't' need those?