Re: [PATCH] mips/bcm63xx: Use BUG_ON instead of if condition followed by BUG

From: Florian Fainelli
Date: Fri Apr 23 2021 - 11:45:48 EST




On 4/23/2021 1:30 AM, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@xxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Subject prefix should have been: MIPS: BCM63XX: Use BUG_ON instead of
condition followed by BUG to match prior submissions done to this
directory. Thanks.
--
Florian