Re: [PATCH] arm64: dts: mt8183: add mediatek,gce-events in mutex

From: Enric Balletbo i Serra
Date: Fri Apr 23 2021 - 09:00:52 EST


Hi Hsin-Yi,

Thank you for your patch.

On 23/4/21 8:53, Hsin-Yi Wang wrote:
> mediatek,gce-events is read by mutex node.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>

Although I know this property is used and needed I didn't find documentation
about it. It would be really nice document in the bindings this mediatek property.

In any case this patch LGTM, so

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..cf22d71161e5 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
> reg = <0 0x14016000 0 0x1000>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> };
>
> larb0: larb@14017000 {
>