Re: [PATCH] staging: media: atomisp: replace pr_info() by dev_info()

[Fabio Aiuto]

On Thu, Apr 22, 2021 at 04:00:37PM +0530, Deepak R Varma wrote:
> It is recommended to use driver model diagnostic macros dev_*() instead
> of pr_*() since the former ensures that the log messages are always
> associated with the corresponding device and driver.
> 
> Suggested-by: Fabio Aiuto <fabioaiuto83@xxxxxxxxx>
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>
> ---
> 
> Note: There are few more pr_into() calls that I have not replaced since
> they are very basic (entry and exit) and temporary. They can be removed 
> if the APIs are fully tested. See this example:
> 	pr_info("%s S\n", __func__);
> 
> Let me know if I should remove them and resubmit this patch.
> 

Hi Deepak,

usually log functions saying "we are here in the code" are not needed,
ftrace is designed for function tracing and other useful things.

I think this patch is aimed for substitution which is logically
different from deletion of function calls.

pr_info deletions can be provided in a separate patch.

Thank you,

fabio