Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang

From: Jeffrey E Altman
Date: Wed Apr 21 2021 - 19:42:09 EST


On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@xxxxxxxxxx) wrote:
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

This change looks good to me. Although I would also be happy with a fallthrough statement being added instead.

Reviewed-by: Jeffrey Altman <jaltman@xxxxxxxxxxxx>

begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@xxxxxxxxxxxx
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard

Attachment: OpenPGP_signature
Description: OpenPGP digital signature