Re: [PATCH] csky: uaccess.h: Coding convention with asm generic

From: Christoph Hellwig
Date: Wed Apr 21 2021 - 10:48:16 EST


On Wed, Apr 21, 2021 at 08:54:15AM +0000, guoren@xxxxxxxxxx wrote:
> From: Guo Ren <guoren@xxxxxxxxxxxxxxxxx>
>
> Using asm-generic/uaccess.h to prevent duplicated code:
> - Add user_addr_max which mentioned in generic uaccess.h
> - Remove custom definitions of KERNEL/USER_DS, get/set_fs,
> uaccess_kerenl

Instead of using the generic definitions removing support for set_fs
entirely would be much preferred. The series in linux-next for mips,
or the riscv version that landed in 5.10 might be good examples.