[PATCH v2] power: supply: cpcap-battery: fix invalid usage of list cursor

From: zhuguangqing83
Date: Wed Apr 21 2021 - 10:37:01 EST


From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>

Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
Empty list or fully traversed list points to list head, which is not
NULL (and before the first element containing real data).

Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
---
v2:
- Modify commit message and code as suggested by Sebastian.
---
drivers/power/supply/cpcap-battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d..a3fc0084cda0 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
break;
}

- if (!d)
+ if (list_entry_is_head(d, &ddata->irq_list, node))
return IRQ_NONE;

latest = cpcap_battery_latest(ddata);
--
2.17.1