Re: [PATCH] regulator: Avoid a double 'of_node_get' in 'regulator_of_get_init_node()'

From: Charles Keepax
Date: Wed Apr 21 2021 - 04:44:03 EST


On Tue, Apr 20, 2021 at 09:31:51PM +0200, Christophe JAILLET wrote:
> 'for_each_available_child_of_node()' already performs an 'of_node_get()'
> on child, so there is no need to perform another one before returning.
> Otherwise, a double 'get' is performed and a resource may never be
> released.
>
> Fixes: 925c85e21ed8 ("regulator: Factor out location of init data OF node")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles