Re: [PATCH] scsi: a100u2w: remove useless variable

[种嘉鹏]

On 2021/4/17 14:34, Julian Calaby wrote:
> Hi Jiapeng,
>
> On Mon, Apr 12, 2021 at 1:23 PM Jiapeng Chong
> <jiapeng.chong@xxxxxxxxxxxxxxxxx> wrote:
> > Fix the following gcc warning:
> >
> > drivers/scsi/a100u2w.c:1092:8: warning: variable ‘bios_phys’ set but not
> > used [-Wunused-but-set-variable].
> >
> > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> > ---
> >   drivers/scsi/a100u2w.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c
> > index 66c5143..855a3fe 100644
> > --- a/drivers/scsi/a100u2w.c
> > +++ b/drivers/scsi/a100u2w.c
> > @@ -1089,7 +1089,6 @@ static int inia100_probe_one(struct pci_dev *pdev,
> >          int error = -ENODEV;
> >          u32 sz;
> >          unsigned long biosaddr;
> > -       char *bios_phys;
> >
> >          if (pci_enable_device(pdev))
> >                  goto out;
> > @@ -1141,7 +1140,7 @@ static int inia100_probe_one(struct pci_dev *pdev,
> >
> >          biosaddr = host->BIOScfg;
> >          biosaddr = (biosaddr << 4);
> > -       bios_phys = phys_to_virt(biosaddr);
> > +       phys_to_virt(biosaddr);
>
> Does phys_to_virt() have side effects? If it doesn't, there's a lot
> more stuff that can get deleted here.
>
> Thanks,
OK, I'll delete phys_to_virt() and send V2.