Re: [PATCH v2] thermal: mediatek: add sensors-support

From: Daniel Lezcano
Date: Tue Apr 20 2021 - 13:11:55 EST


On 20/04/2021 17:54, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> add HWMON-support to mediateks thermal driver to allow lm-sensors
> userspace tools read soc temperature
>
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> ---
> v2: drop ifdef and used devm_thermal_add_hwmon_sysfs
> ---
> drivers/thermal/mtk_thermal.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 149c6d7fd5a0..32be8a715c7d 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -23,6 +23,8 @@
> #include <linux/reset.h>
> #include <linux/types.h>
>
> +#include "thermal_hwmon.h"
> +
> /* AUXADC Registers */
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> @@ -1087,6 +1089,11 @@ static int mtk_thermal_probe(struct platform_device *pdev)
> goto err_disable_clk_peri_therm;
> }
>
> + tzdev->tzp->no_hwmon = false;

^^^^^^ you can drop this line

> + ret = devm_thermal_add_hwmon_sysfs(tzdev);
> + if (ret)
> + dev_err(&pdev->dev, "error in thermal_add_hwmon_sysfs");
> +
> return 0;
>
> err_disable_clk_peri_therm:
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog