Re: [PATCH v2] staging: media: atomisp: pci: Change line break to avoid an open parenthesis at the end of the line

From: Hans Verkuil
Date: Tue Apr 20 2021 - 08:41:34 EST


On 15/04/2021 19:08, Aline Santana Cordeiro wrote:
> Change line break to avoid an open parenthesis at the end of the line.
> It consequently removed spaces at the start of the subsequent line.
> Both issues detected by checkpatch.pl.
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@xxxxxxxxx>
> ---
>
> Changes since v1:
> - Keep the * with the function return type
> instead of left it with the function name
>
> drivers/staging/media/atomisp/pci/atomisp_cmd.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.h b/drivers/staging/media/atomisp/pci/atomisp_cmd.h
> index 1c0d464..e2b36fa 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.h
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.h
> @@ -75,8 +75,8 @@ void atomisp_wdt(struct timer_list *t);
> void atomisp_setup_flash(struct atomisp_sub_device *asd);
> irqreturn_t atomisp_isr(int irq, void *dev);
> irqreturn_t atomisp_isr_thread(int irq, void *isp_ptr);
> -const struct atomisp_format_bridge *get_atomisp_format_bridge_from_mbus(
> - u32 mbus_code);
> +const struct atomisp_format_bridge*

Keep the space before the *!

Regards,

Hans

> +get_atomisp_format_bridge_from_mbus(u32 mbus_code);
> bool atomisp_is_mbuscode_raw(uint32_t code);
> int atomisp_get_frame_pgnr(struct atomisp_device *isp,
> const struct ia_css_frame *frame, u32 *p_pgnr);
> @@ -381,9 +381,9 @@ enum mipi_port_id __get_mipi_port(struct atomisp_device *isp,
>
> bool atomisp_is_vf_pipe(struct atomisp_video_pipe *pipe);
>
> -void atomisp_apply_css_parameters(
> - struct atomisp_sub_device *asd,
> - struct atomisp_css_params *css_param);
> +void atomisp_apply_css_parameters(struct atomisp_sub_device *asd,
> + struct atomisp_css_params *css_param);
> +
> void atomisp_free_css_parameters(struct atomisp_css_params *css_param);
>
> void atomisp_handle_parameter_and_buffer(struct atomisp_video_pipe *pipe);
>