Re: [PATCH] PCI: acpiphp: Fixed coding style

From: Bjorn Helgaas
Date: Fri Apr 16 2021 - 15:36:07 EST


On Mon, Mar 01, 2021 at 12:51:45PM +0530, chakravarthikulkarni wrote:
> In this commit fixed coding style for braces and comments.
>
> Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@xxxxxxxxx>

Applied to pci/hotplug for v5.13, thanks!

I dropped the comment change because it's really one comment that
should remain connected, so it doesn't seem like an improvement to me
to add comment start/stop in the middle.

> ---
> drivers/pci/hotplug/acpiphp.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index a74b274a8c45..e0964600a78f 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -80,8 +80,8 @@ struct acpiphp_bridge {
> struct acpiphp_slot {
> struct list_head node;
> struct pci_bus *bus;
> - struct list_head funcs; /* one slot may have different
> - objects (i.e. for each function) */
> + struct list_head funcs; /* one slot may have different */
> + /* objects (i.e. for each function) */
> struct slot *slot;
>
> u8 device; /* pci device# */
> @@ -148,8 +148,7 @@ static inline struct acpiphp_root_context *to_acpiphp_root_context(struct acpi_h
> * ACPI has no generic method of setting/getting attention status
> * this allows for device specific driver registration
> */
> -struct acpiphp_attention_info
> -{
> +struct acpiphp_attention_info {
> int (*set_attn)(struct hotplug_slot *slot, u8 status);
> int (*get_attn)(struct hotplug_slot *slot, u8 *status);
> struct module *owner;
> --
> 2.17.1
>