Re: [PATCH] irqchip/xilinx: Expose Kconfig option

From: Marc Zyngier
Date: Fri Apr 16 2021 - 09:41:14 EST


On Fri, 16 Apr 2021 00:32:50 +0100,
Robert Hancock <robert.hancock@xxxxxxxxxx> wrote:
>
> Previously the XILINX_INTC config option was hidden and only
> auto-selected on the MicroBlaze platform. However, this IP can also be
> used on other platforms. Allow this option to be user-enabled.
>
> Signed-off-by: Robert Hancock <robert.hancock@xxxxxxxxxx>

I don't think this is a good idea. In general, people have no idea
which interrupt controller they need to select. So you either end-up
with a missing interrupt controller, or a bunch you really don't need.

This is essentially a platform constraint, and this should directly be
selected by the platform if you have this IP in your system.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.