Re: [PATCH] drivers: ipa: Fix missing IRQF_ONESHOT as only threaded handler

[Alex Elder]

On 4/15/21 10:40 PM, zhuguangqing83@xxxxxxxxx wrote:
> From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>

This is not required here.	-Alex

https://lore.kernel.org/netdev/d57e0a43-4d87-93cf-471c-c8185ea85ced@xxxxxxxx/

> Coccinelle noticed:
> drivers/net/ipa/ipa_smp2p.c:186:7-27: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
> ---
>   drivers/net/ipa/ipa_smp2p.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index a5f7a79a1923..74e04427a711 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -183,7 +183,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
>   	}
>   	irq = ret;
>   
> -	ret = request_threaded_irq(irq, NULL, handler, 0, name, smp2p);
> +	ret = request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT,
> +				   name, smp2p);
>   	if (ret) {
>   		dev_err(dev, "error %d requesting \"%s\" IRQ\n", ret, name);
>   		return ret;