Re: [PATCH] Fix 'assignment to __be16' warning

From: Wolfram Sang
Date: Thu Apr 15 2021 - 16:19:43 EST


Hi Bence,

On Mon, Apr 12, 2021 at 11:53:02AM +0000, Bence Csókás wrote:
> While the preamble field _is_ technically big-endian, its value is always 0x2A2A,
> which is the same in either endianness, therefore it should be u16 instead.

Why should it be u16? I don't see it.

I thought the fix would be to add the suffix 'U' to 0x2A2A when it is
assigned to preamble?

Also, please use "i2c: cp2615: <patch header>" in the $subject

Happy hacking,

Wolfram

Attachment: signature.asc
Description: PGP signature