Re: [PATCH 02/57] staging: android: ashmem: Supply description for 'new_range'

From: Todd Kjos
Date: Thu Apr 15 2021 - 12:31:02 EST


On Wed, Apr 14, 2021 at 11:11 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/staging/android/ashmem.c:189: warning: Function parameter or member 'new_range' not described in 'range_alloc'
>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "Arve Hjønnevåg" <arve@xxxxxxxxxxx>
> Cc: Todd Kjos <tkjos@xxxxxxxxxxx>
> Cc: Martijn Coenen <maco@xxxxxxxxxxx>
> Cc: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>
> Cc: Christian Brauner <christian@xxxxxxxxxx>
> Cc: Hridya Valsaraju <hridya@xxxxxxxxxx>
> Cc: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Cc: Robert Love <rlove@xxxxxxxxxx>
> Cc: linux-staging@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Acked-by: Todd Kjos <tkjos@xxxxxxxxxx>

> ---
> drivers/staging/android/ashmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index d66a64e42273a..8ee4320a5dc6d 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -179,6 +179,7 @@ static inline void lru_del(struct ashmem_range *range)
> * @purged: Initial purge status (ASMEM_NOT_PURGED or ASHMEM_WAS_PURGED)
> * @start: The starting page (inclusive)
> * @end: The ending page (inclusive)
> + * @new_range: The placeholder for the new range
> *
> * This function is protected by ashmem_mutex.
> */
> --
> 2.27.0
>