Re: [RFC] Improve workload error in 'perf record'

From: Ian Rogers
Date: Thu Apr 15 2021 - 01:33:58 EST


On Wed, Apr 14, 2021 at 6:16 AM Arnaldo Carvalho de Melo
<acme@xxxxxxxxxx> wrote:
>
> Hi,
>
> Please take a look,
>
> Best regards,

Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Having been confused by this for a case in the past, thanks! It'd be
nice for code coverage's sake to have a shell test on this.

Thanks,
Ian

> - Arnaldo
>
> Arnaldo Carvalho de Melo (2):
> perf evlist: Add a method to return the list of evsels as a string
> perf record: Improve 'Workload failed' message printing events + what
> was exec'ed
>
> tools/perf/builtin-record.c | 8 ++++++--
> tools/perf/util/evlist.c | 19 +++++++++++++++++++
> tools/perf/util/evlist.h | 2 ++
> 3 files changed, 27 insertions(+), 2 deletions(-)
>
> --
> 2.26.2
>