Re: [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers

From: Marc Kleine-Budde
Date: Wed Apr 14 2021 - 11:43:40 EST


On 14.04.2021 19:35:15, Aswath Govindraju wrote:
> The following series of patches add support for CAN transceivers.
>
> TCAN1042 has a standby signal that needs to be pulled high for
> sending/receiving messages[1]. TCAN1043 has a enable signal along with
> standby signal that needs to be pulled up for sending/receiving
> messages[2], and other combinations of the two lines can be used to put the
> transceiver in different states to reduce power consumption. On boards
> like the AM654-idk and J721e-evm these signals are controlled using gpios.
>
> Patch 1 rewords the comment that restricts max_link_rate attribute to have
> units of Mbps.
>
> Patch 2 adds an API for devm_of_phy_optional_get_by_index

You probably want to split this into 2 or even 3 separate series. The
first one would be patches 1+2 then 3+4 they can go via the phy tree.
Patches 5+6 can go via linux-can-next

> Patch 3 models the transceiver as a phy device tree node with properties
> for max bit rate supported, gpio properties for indicating gpio pin numbers
> to which standby and enable signals are connected.
>
> Patch 4 adds a generic driver to support CAN transceivers.
>
> Patches 5 & 6 add support for implementing the transceiver as a phy of
> m_can_platform driver.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature