RE: [PATCH] Drivers: hv: vmbus: remove unused function

From: Michael Kelley
Date: Wed Apr 14 2021 - 10:48:22 EST


From: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> Sent: Tuesday, April 13, 2021 11:21 PM
>
> Fix the following clang warning:
>
> drivers/hv/ring_buffer.c:89:1: warning: unused function
> 'hv_set_next_read_location' [-Wunused-function].
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/hv/ring_buffer.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index 35833d4..78d4043 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -84,15 +84,6 @@ static void hv_signal_on_write(u32 old_write, struct vmbus_channel
> *channel)
> ring_info->ring_buffer->write_index = next_write_location;
> }
>
> -/* Set the next read location for the specified ring buffer. */
> -static inline void
> -hv_set_next_read_location(struct hv_ring_buffer_info *ring_info,
> - u32 next_read_location)
> -{
> - ring_info->ring_buffer->read_index = next_read_location;
> - ring_info->priv_read_index = next_read_location;
> -}
> -
> /* Get the size of the ring buffer. */
> static inline u32
> hv_get_ring_buffersize(const struct hv_ring_buffer_info *ring_info)
> --
> 1.8.3.1

This function became unused as of commit 4226ff69a3df
("vmbus: simplify hv_ringbuffer_read") on 7/17/2017.

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>