Re: [PATCH v3 2/3] drm: bridge: add it66121 driver

[Neil Armstrong]

Hi Rob,

Le 13/04/2021 à 22:21, Robert Foss a écrit :
> Hey Neil & Phong,
> 
> Thanks for submitting this series!
> 
>> +
>> +static const struct drm_bridge_funcs it66121_bridge_funcs = {
>> +       .attach = it66121_bridge_attach,
>> +       .enable = it66121_bridge_enable,
>> +       .disable = it66121_bridge_disable,
>> +       .mode_set = it66121_bridge_mode_set,
>> +       .mode_valid = it66121_bridge_mode_valid,
>> +       .detect = it66121_bridge_detect,
>> +       .get_edid = it66121_bridge_get_edid,
>> +       .atomic_get_output_bus_fmts = it66121_bridge_atomic_get_output_bus_fmts,
>> +       .atomic_get_input_bus_fmts = it66121_bridge_atomic_get_input_bus_fmts,
>> +};
> 
> I would like to see an implementation of HPD, since it is supported by
> the hardware[1] (and required by the documentation). IRQ status bit 0
> seems to be the responsible for notifying us about hot plug detection
> events.

It's implemented in the IRQ handler with the IT66121_INT_STATUS1_HPD_STATUS event.

Neil

> 
> [1] https://rockchip.fr/radxa/IT66121_Programming_Guide.v1.05.pdf
> 
> 
> Rob.
>