Re: [PATCH net-next] net: Space: remove hp100 probe

From: Stephen Hemminger
Date: Tue Apr 13 2021 - 18:42:16 EST


On Tue, 13 Apr 2021 16:16:17 +0200
Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The driver was removed last year, but the static initialization got left
> behind by accident.
>
> Fixes: a10079c66290 ("staging: remove hp100 driver")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/net/Space.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/Space.c b/drivers/net/Space.c
> index 7bb699d7c422..a61cc7b26a87 100644
> --- a/drivers/net/Space.c
> +++ b/drivers/net/Space.c
> @@ -59,9 +59,6 @@ static int __init probe_list2(int unit, struct devprobe2 *p, int autoprobe)
> * look for EISA/PCI cards in addition to ISA cards).
> */
> static struct devprobe2 isa_probes[] __initdata = {
> -#if defined(CONFIG_HP100) && defined(CONFIG_ISA) /* ISA, EISA */
> - {hp100_probe, 0},
> -#endif
> #ifdef CONFIG_3C515
> {tc515_probe, 0},
> #endif

Thanks, do we even need to have the static initialization anymore?