Re: [PATCH 1/1] seccomp: Always "goto wait" if the list is empty

From: Rodrigo Campos
Date: Tue Apr 13 2021 - 14:03:24 EST


On Tue, Apr 13, 2021 at 7:54 PM Christian Brauner
<christian.brauner@xxxxxxxxxx> wrote:
> > Fixes: 7cf97b1254550
> > Cc: stable@xxxxxxxxxxxxxxx # 5.9+
> > Signed-off-by: Rodrigo Campos <rodrigo@xxxxxxxxxx>
> > ---
>
> So the agent will see the return value from
> wait_for_completion_interruptible() and know that the addfd wasn't
> successful and the target will notice that no addfd request has actually
> been added and essentially try again. Seems like a decent fix and can be

Yes, exactly!

> backported cleanly. I assume seccomp testsuite passes.

Yes, seccomp selftests (tools/testing/selftests/seccomp/seccomp_bpf) passes fine

> Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>

Thanks!