Re: [PATCH v2] staging: media: zoran: moved statement to next line with '*'

From: Hans Verkuil
Date: Tue Apr 13 2021 - 10:27:37 EST


On 09/04/2021 13:40, Mitali Borkar wrote:
> Moved the statement to next line and added '*' before it to meet
> linux kernel coding style for long(multi-line) comments.
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@xxxxxxxxx>
> ---
>
> Changes from v1:- made style changes according to linux kernel coding style
> for long comments.
>
> drivers/staging/media/zoran/zr36060.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/zoran/zr36060.c b/drivers/staging/media/zoran/zr36060.c
> index 035634fc1c6d..8c6f4d792a9d 100644
> --- a/drivers/staging/media/zoran/zr36060.c
> +++ b/drivers/staging/media/zoran/zr36060.c
> @@ -249,7 +249,8 @@ static const char zr36060_ta[8] = { 0, 1, 1, 0, 0, 0, 0, 0 }; //table idx's AC
> static const char zr36060_decimation_h[8] = { 2, 1, 1, 0, 0, 0, 0, 0 };
> static const char zr36060_decimation_v[8] = { 1, 1, 1, 0, 0, 0, 0, 0 };
>
> -/* SOF (start of frame) segment depends on width,
> +/*
> + * SOF (start of frame) segment depends on width,
> * height and sampling ratio of each color component
> */
> static int zr36060_set_sof(struct zr36060 *ptr)
>

Same problem as with other patches: this sits on top of your v1, so won't apply
to mainline code.

Regards,

Hans