Re: [PATCH v4 1/3] kunit: make test->lock irq safe

From: Brendan Higgins
Date: Tue Apr 13 2021 - 09:38:28 EST


On Tue, Apr 13, 2021 at 3:07 AM <glittao@xxxxxxxxx> wrote:
>
> From: Vlastimil Babka <vbabka@xxxxxxx>
>
> The upcoming SLUB kunit test will be calling kunit_find_named_resource() from
> a context with disabled interrupts. That means kunit's test->lock needs to be
> IRQ safe to avoid potential deadlocks and lockdep splats.
>
> This patch therefore changes the test->lock usage to spin_lock_irqsave()
> and spin_unlock_irqrestore().
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Oliver Glitta <glittao@xxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Thanks!