Re: [PATCH 01/11] mm/page_alloc: Split per cpu page lists and zone stats

From: Mel Gorman
Date: Tue Apr 13 2021 - 09:27:20 EST


On Mon, Apr 12, 2021 at 07:43:18PM +0200, Vlastimil Babka wrote:
> On 4/7/21 10:24 PM, Mel Gorman wrote:
> > @@ -6691,7 +6697,7 @@ static __meminit void zone_pcp_init(struct zone *zone)
> > * relies on the ability of the linker to provide the
> > * offset of a (static) per cpu variable into the per cpu area.
> > */
> > - zone->pageset = &boot_pageset;
> > + zone->per_cpu_pageset = &boot_pageset;
>
> I don't see any &boot_zonestats assignment here in zone_pcp_init() or its
> caller(s), which seems strange, as zone_pcp_reset() does it.
>

Yes, it's required, well spotted!

--
Mel Gorman
SUSE Labs