Re: [PATCH] sched: remove the redundant comments

From: Dietmar Eggemann
Date: Tue Apr 13 2021 - 04:36:15 EST


On 12/04/2021 09:39, Hui Su wrote:
> Since the commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]"),
> we don't need this any more.
>
> Signed-off-by: Hui Su <suhui@xxxxxxxx>
> ---
> kernel/sched/sched.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 10a1522b1e30..2232022d8561 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> struct rq {
> /* runqueue lock: */
> raw_spinlock_t lock;
> -
> - /*
> - * nr_running and cpu_load should be in the same cacheline because
> - * remote CPUs use both these fields when doing load calculation.
> - */
> unsigned int nr_running;
> #ifdef CONFIG_NUMA_BALANCING
> unsigned int nr_numa_running;

I forgot to remove this snippet back then. LGTM.

Add a

Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")

line.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>