Re: [PATCH net-next 6/7] net: stmmac: Enable RX via AF_XDP zero-copy

From: David Miller
Date: Mon Apr 12 2021 - 17:19:29 EST


+ /* synchronize_rcu() needed for pending XDP buffers to drain */
+ for (queue = 0; queue < rx_queues_cnt; queue++) {
+ rx_q = &priv->rx_queue[queue];
+ if (rx_q->xsk_pool) {
+ synchronize_rcu();

Are you sure this is safe here, especially via the ->ndo_setup_tc() code path?

Thank you.