Re: [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses

From: Joe Perches
Date: Mon Apr 12 2021 - 16:47:00 EST


On Mon, 2021-04-12 at 16:52 +0530, Mitali Borkar wrote:
> Removed unnecessary parentheses because they must be used only when it
> is necessary or they improve readability.
> Reported by checkpatch.

I gave you feedback about the memset changes.
Please use it.
https://lore.kernel.org/lkml/f5fe04d62b22eb5e09c299e769d9b9d8917f119c.camel@xxxxxxxxxxx/

> Changes from v3:- No changes.
> Changes from v2:- Rectified spelling mistake in subject description.
> Changes has been made in v3.
> Changes from v1:- No changes.
[]
> diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
[]
> @@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
>   pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
>   pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
>  
>
> - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> + memset((void *)(&pHTInfo->SelfHTCap), 0,
>   sizeof(pHTInfo->SelfHTCap));

memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap);

etc...