Re: [PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings

From: Rob Herring
Date: Mon Apr 12 2021 - 14:32:25 EST


On Fri, Apr 09, 2021 at 03:40:21PM -0500, Alex Elder wrote:
> Add existing supported platform "qcom,sc7180-ipa" to the set of IPA
> compatible strings. Also add newly-supported "qcom,sdx55-ipa",
> "qcom,sc7280-ipa".
>
> Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 8f86084bf12e9..2645a02cf19bf 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -43,7 +43,11 @@ description:
>
> properties:
> compatible:
> - const: "qcom,sdm845-ipa"
> + oneOf:
> + - const: "qcom,sc7180-ipa"
> + - const: "qcom,sc7280-ipa"
> + - const: "qcom,sdm845-ipa"
> + - const: "qcom,sdx55-ipa"

Use enum instead of oneOf + const. And drop the quotes.

>
> reg:
> items:
> --
> 2.27.0
>