Re: [PATCH 2/5] mm/memcg: Introduce obj_cgroup_uncharge_mod_state()

From: Shakeel Butt
Date: Mon Apr 12 2021 - 11:51:09 EST


On Fri, Apr 9, 2021 at 4:19 PM Waiman Long <longman@xxxxxxxxxx> wrote:
>
> In memcg_slab_free_hook()/pcpu_memcg_free_hook(), obj_cgroup_uncharge()
> is followed by mod_objcg_state()/mod_memcg_state(). Each of these
> function call goes through a separate irq_save/irq_restore cycle. That
> is inefficient. Introduce a new function obj_cgroup_uncharge_mod_state()
> that combines them with a single irq_save/irq_restore cycle.
>
> Signed-off-by: Waiman Long <longman@xxxxxxxxxx>

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>