Re: [PATCH 4/5] ASoC: lpass: use the clock provider API

[Srinivas Kandagatla]

On 12/04/2021 13:17, Jerome Brunet wrote:
> > >    -	return of_clk_add_provider(np, of_clk_src_simple_get, va->hw.clk);
> > > +	return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, &va->hw);
> > Now that we convert this to devm, You missed error path and driver remove
> > where we delete clk provider. This should be removed as well as part of
> > this patch.
> Indeed. I should not have switched to devm here - It was not really the
> purpose of the patch. Habits I guess.
>
> Do you prefer I stick with devm (with the suggested fix) or revert to the
> no-devm way for the v2 ? It makes no difference to me TBH.

devm should be good.

--srini
>