Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

From: Vincent MAILHOL
Date: Mon Apr 12 2021 - 07:23:24 EST


Hi Marc,

On Mon. 12 Apr 2021 at 18:20, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 10.04.2021 18:59:45, Vincent Mailhol wrote:
> > Here comes the 15th iteration of the patch. This new version addresses
> > the comments received from Marc (thanks again for the review!) and
> > simplify the device probing by using .driver_info.
>
> diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c b/drivers/net/can/usb/etas_es58x/es58x_core.c
> index 35ba8af89b2e..7222b3b6ca46 100644
> --- a/drivers/net/can/usb/etas_es58x/es58x_core.c
> +++ b/drivers/net/can/usb/etas_es58x/es58x_core.c
> @@ -1096,7 +1096,7 @@ static void es58x_increment_rx_errors(struct es58x_device *es58x_dev)
> * be aligned.
> *
> * Sends the URB command to the device specific function. Manages the
> - * errors throwed back by those functions.
> + * errors thrown back by those functions.
> */
> static void es58x_handle_urb_cmd(struct es58x_device *es58x_dev,
> const union es58x_urb_cmd *urb_cmd)
>
> I have applied to linux-can-next/testing with the above spell fix.
> Thanks for the steady work on this and all the other features.

Thanks to you too! This, together with the other features is my
very first open source contribution. I learned a lot from you,
Oliver and the others from the mailing list. It was a nice
experience.

That said, you will eventually hear from me again on the TDC
netlink interface (and probably other topics as well).


Yours sincerely,
Vincent