Re: [PATCH] platform/x86: pmc_atom: Match all Beckhoff Automation baytrail boards with critclk_systems DMI table

From: Andy Shevchenko
Date: Mon Apr 12 2021 - 05:56:26 EST


On Mon, Apr 12, 2021 at 12:29 PM Steffen Dirkwinkel
<linux-kernel-dev@xxxxxxxxxxxx> wrote:
>
> From: Steffen Dirkwinkel <s.dirkwinkel@xxxxxxxxxxxx>
>
> pmc_plt_clk* clocks are used for ethernet controllers so need to stay
> turned on. This adds the affected board family to critclk_systems DMI
> table so the clocks are marked as CLK_CRITICAL and not turned off.
>
> This replaces the previosly listed boards with a match for the whole

"...previously..."

> device family. There are new affected boards that would otherwise need
> to be listed. There are only few unaffected boards in the family and

"...only a few..."

> having the clocks turned on is not an issue on those.

"...not an issue."

> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@xxxxxxxxxxxx>

I'm afraid it's a bit too much. Is there any guarantee all the boards
based on x86 will be Baytrail only?

--
With Best Regards,
Andy Shevchenko