Re: [Outreachy kernel] [PATCH] staging: rtl8192u: Remove variable set but not used

From: Greg KH
Date: Mon Apr 12 2021 - 05:46:09 EST


On Sun, Apr 11, 2021 at 08:12:05PM +0200, Fabio M. De Francesco wrote:
> On Sunday, April 11, 2021 7:43:57 PM CEST Julia Lawall wrote:
> > On Sun, 11 Apr 2021, Fabio M. De Francesco wrote:
> > > Remove variable "int ret" which is instantiated but not used.
> >
> > instantiated -> declared? I thought instantiated could mean initialized,
> > but that doesn't seem to be the case.
> >
> > julia
> Please, help me to remind...
>
> If a local variable is declared but not set to any value, does it take
> space on the stack?

Maybe, maybe not, doesn't matter either way.

> If I understand your message, it does not. Therefore it is only declared
> but no memory is allocated for it (i.e., it is not instantiated). Right?
>
> If you confirm I've understood this topic, I can send a v2 patch.

That's not the issue here at all...

confused,

greg k-h