Re: [PATCH v3] staging: rtl8723bs: remove unnecessary goto jumps
From: Bryan Brattlof
Date: Sun Apr 11 2021 - 09:05:54 EST
On Sun, Apr 11, 2021 at 08:43:05AM +0200, Greg Kroah-Hartman wrote:
>
>On Sat, Apr 10, 2021 at 03:27:02PM +0000, Bryan Brattlof wrote:
>> The next instruction for both 'goto exit' jump statements is to
>> execute the exit jump instructions regardless. We can safely
>> remove all jump statements from __init rtw_drv_entry()
>>
>> This will also remove the extra line-break before module_init()
>> that checkpatch.pl was concerned with.
>
>When you say "also", that almost always means it should be a separate
>patch. Please do so here, try to do only "one logical thing" per kernel
>patch please.
>
Will do.
I'll resubmit a clean v4 without the extra bits.
>
>thanks,
>
>greg k-h
--
~Brayn